Add support for [*] in trusted hosts
#2480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kludex requesting your review and inputs for this PR :) |
Kludex
reviewed
Oct 5, 2024
Kludex
reviewed
Oct 5, 2024
| @@ -65,7 +65,7 @@ def make_httpx_client( | |||
| "::11.22.33.44", # This is a dual address | |||
| ] | |||
| _TRUSTED_IPv6_NETWORKS = "2001:db8:abcd:0012::0/64" | |||
| _TRUSTED_LITERALS = "some-literal , unix:///foo/bar , /foo/bar" | |||
| _TRUSTED_LITERALS = "some-literal , unix:///foo/bar , /foo/bar, garba*gewith*" | |||
There was a problem hiding this comment.
We probably have an assertive test case with *, can you add [*] as well?
There was a problem hiding this comment.
Added test case with trust host using ["*"], It's similar to the existing trust everything so I did not add every address as an input.
|
Please change the title as well. |
theyashl
changed the title
Kludex
changed the title
[*] in trusted hosts
raf-moreau
pushed a commit
to raf-moreau/uvicorn
that referenced
this pull request
Nov 5, 2024
* fixed trusted host parsing for always trust case * Update uvicorn/middleware/proxy_headers.py * added test case for trust everything using list --------- Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed trusted host parsing for always trust case.
This PR will fix allowing all networks upon passing
--forwarded-allow-ipsas*from gunicorn with uvicorn as a worker class.The fix ensures that gunicorn integration and uvicorn as a standalone application will work fine for storing and validating trusted networks.
Complete RCA is present on issue: #2477
Checklist